Delete single filter button #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds fully functional delete buttons to the filter chips on the Events Discovery page, replacing previous non-interactive UI elements.
- Implements
onDeletedcallbacks for Location, Date Range, and Price chips - Replaces
copyWith()with explicitEventFilterModelconstructors to clear individual filters - Resets pagination and reloads events after filter removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete single filter button functionality
Implements working delete ("x") buttons for individual filter chips on the Events Discovery page.
Changes:
onDeletedcallbacks to Location, Date Range, and Price filter chipscopyWith()calls with explicitEventFilterModelconstructors to ensure proper filter removalFixes: Filter chips now have functional delete buttons that actually remove the applied filters instead of being non-interactive.